• 201 Posts
  • 2.02K Comments
Joined 1 year ago
cake
Cake day: June 4th, 2025

help-circle









  • I mean, what we have now is a clique of ideologically-aligned people who insta-approve each other’s bad PRs outside their domain and ignore or jam-up the PRs of people outside their clique.

    You can say it’s a failure of management, but this is the primary tool used by the ideologues. And I’ve seen it used so at various places.

    What I haven’t seen is a real dissemination of knowledge about the code via review. At least not above and beyond what can be achieved by looking at the code and using blame to see the changesets and looking at the associated issues.



  • Why would you ask permission to do something necessary? Just do it any time you have a ticket in the area.

    One place I worked at had a rule forbidding pure refactors. One, it’s no other department’s (or manager’s) business that you massaged something to be more useful. Two, what is QA supposed to do with a change that has no new features or bug fixes? Three, are you going to put “refactor” in your release notes? Four, why are you refactoring things out of the scope of a feature or bugfix?