Seeing that Uncle Bob is making a new version of Clean Code I decided to try and find this article about the original.

  • dandi8@fedia.io
    link
    fedilink
    arrow-up
    0
    ·
    5 months ago

    It’s only as incomprehensible as you make it.

    If there are 6 subfunctions, that means there’s 6 levels of abstraction (assuming the method extraction was not done blindly), which further suggests that maybe they should actually be part of a different class (or classes). Why would you be interested in 6 levels of abstraction at once?

    But we’re arguing hypotheticals here. Of course you can make the method implementations a complete mess, the book cannot guarantee that the person applying the principles used their brain, as well.

    • BatmanAoD@programming.dev
      link
      fedilink
      arrow-up
      0
      ·
      5 months ago

      Because abstractions leak. Heck, abstractions are practically lies most of the time.

      What’s the most time-consuming thing in programming? Writing new features? No, that’s easy. It’s figuring out where a bug is in existing code.

      How do abstractions help with that? Can you tell, from the symptoms, which “level of abstraction” contains the bug? Or do you need to read through all six (or however many) “levels”, across multiple modules and functions, to find the error? Far more commonly, it’s the latter.

      And, arguably worse, program misbehavior is often due to unexpected interactions between components that appear to work in isolation. This means that there isn’t a single “level of abstraction” at which the bug manifests, and also that no amount of unit testing would have prevented the bug.

      • dandi8@fedia.io
        link
        fedilink
        arrow-up
        0
        ·
        5 months ago

        How do abstractions help with that? Can you tell, from the symptoms, which “level of abstraction” contains the bug? Or do you need to read through all six (or however many) “levels”, across multiple modules and functions, to find the error?

        I usually start from the lowest abstraction, where the stack trace points me and don’t need to look at the rest, because my code is written well.

    • FizzyOrange@programming.dev
      link
      fedilink
      arrow-up
      0
      ·
      5 months ago

      Why would you be interested in 6 levels of abstraction at once?

      Because there aren’t 6 interesting levels of abstraction. It’s like talking to a child:

      What are you doing?

      Finances

      What does that involve?

      Processing money.

      What kind of processing?

      Summarising

      What kind of summaries?

      Summaries of everything

      What specifically though?

      Summaries

      Ok so you’re just displaying total balance then…